Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4704#discussion_r28548303
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ---
@@ -29,7 +29,22 @@ import org.apache.spark.sql.types.{StructField,
StructType}
/**
* Params for [[StandardScaler]] and [[StandardScalerModel]].
*/
-private[feature] trait StandardScalerParams extends Params with
HasInputCol with HasOutputCol
+private[feature] trait StandardScalerParams extends Params with
HasInputCol with HasOutputCol {
+
+ /**
+ * Whether to center the data before scaling
--- End diff --
Could you please state the default here?
Also, can you please add this warning (copied & edited from the class doc
in the old class):
```
When `withMean` is true, the output vectors will be dense, so this does not
work on sparse input and will raise an exception. When `withMean` is false,
the input can be dense or sparse.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
