Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/5548#discussion_r28581367
--- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala ---
@@ -245,7 +245,7 @@ class ContextCleanerSuite extends
ContextCleanerSuiteBase {
assert(fs.exists(RDDCheckpointData.rddCheckpointDataPath(sc,
rddId).get))
// Test that GC causes checkpoint data cleanup after dereferencing the
RDD
- postGCTester = new CleanerTester(sc, Seq(rddId), Nil, Nil)
+ postGCTester = new CleanerTester(sc, Seq(rddId), Nil, Nil, Seq(rddId))
--- End diff --
@srowen This is just a test code bug. `new CleanerTester(sc, Seq(rddId),
Nil, Nil)` This code is only to ensure that the RDD is cleaned, but
checkpoint. rdd and checkpoint almost simultaneously be cleaned, But there are
exceptions, depending on the GC. The `checkpointCleaned ` ensure the
checkpoint is cleaned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
