Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4807#issuecomment-94041899
@hhbyyh I agree with points 1-4.
One clarification:
{quote}
A few questions:
Based on previous discussion, users can specify algorithms by
1. passing String parameter to LDA.run. (hard to specify parameter)
2. or through setOptimizer of LDA. (a little tricky to set default
Optimizer)
{quote}
Not quite. This is what I had in mind for LDA optimizer parameter setting:
```
def setOptimizer(value: Optimizer): LDA = ??? // set via Optimizer,
constructed beforehand
def setOptimizer(value: String): LDA = ??? // set with optimizer name
("em"), using default optimizer parameters
```
I did not intend for us to pass extra parameters to the run() method.
I'll respond to the Online LDA-specific items in the other PR:
[https://github.com/apache/spark/pull/4419]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
