aokolnychyi commented on a change in pull request #30558:
URL: https://github.com/apache/spark/pull/30558#discussion_r543286779
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -185,6 +185,9 @@ abstract class Optimizer(catalogManager: CatalogManager)
RemoveLiteralFromGroupExpressions,
RemoveRepetitionFromGroupExpressions) :: Nil ++
operatorOptimizationBatch) :+
+ // This batch rewrites data source plans and should be run after the
operator
+ // optimization batch and before any batches that depend on stats.
+ Batch("Data Source Rewrite Rules", Once, dataSourceRewriteRules: _*) :+
Review comment:
@HyukjinKwon, no, I meant I'd rather work on the name together to make
sure it is good enough rather than revert the change. Here is a quote from my
earlier comment:
> I'd fix the name and cherry-pick it to 3.1 rather than revert the change
completely.
I think we are on the same page here and I'll fix the name as part of
SPARK-33784. Thanks for creating it, btw!
Currently proposed names are:
- `postOperatorOptimizationRules`
- `preCostBasedOptimizationRules`
- `preCBORules`
What does everybody think about them? Any preferences?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
