cloud-fan commented on a change in pull request #30779:
URL: https://github.com/apache/spark/pull/30779#discussion_r543357240
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterTableAddPartitionSuiteBase.scala
##########
@@ -17,48 +17,17 @@
package org.apache.spark.sql.execution.command
-import org.scalactic.source.Position
-import org.scalatest.Tag
-
-import org.apache.spark.sql.{AnalysisException, QueryTest, Row}
+import org.apache.spark.sql.{AnalysisException, QueryTest}
import org.apache.spark.sql.catalyst.analysis.PartitionsAlreadyExistException
import org.apache.spark.sql.catalyst.catalog.CatalogTypes.TablePartitionSpec
-import org.apache.spark.sql.execution.datasources.PartitioningUtils
import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.test.SQLTestUtils
-trait AlterTableAddPartitionSuiteBase extends QueryTest with SQLTestUtils {
- protected def version: String
- protected def catalog: String
+trait AlterTableAddPartitionSuiteBase extends QueryTest with
DDLCommandTestUtils {
+ override val command = "ALTER TABLE .. ADD PARTITION"
protected def defaultUsing: String
Review comment:
why we still have it here?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterTableDropPartitionSuiteBase.scala
##########
@@ -17,47 +17,16 @@
package org.apache.spark.sql.execution.command
-import org.scalactic.source.Position
-import org.scalatest.Tag
-
-import org.apache.spark.sql.{AnalysisException, QueryTest, Row}
-import org.apache.spark.sql.execution.datasources.PartitioningUtils
+import org.apache.spark.sql.{AnalysisException, QueryTest}
import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.test.SQLTestUtils
-trait AlterTableDropPartitionSuiteBase extends QueryTest with SQLTestUtils {
- protected def version: String
+trait AlterTableDropPartitionSuiteBase extends QueryTest with
DDLCommandTestUtils {
+ override val command = "ALTER TABLE .. DROP PARTITION"
protected def catalog: String
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
