beliefer commented on a change in pull request #30387:
URL: https://github.com/apache/spark/pull/30387#discussion_r544089977
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -116,13 +116,21 @@ trait WindowExecBase extends UnaryExecNode {
* [[WindowExpression]]s and factory function for the
[[WindowFrameFunction]].
*/
protected lazy val windowFrameExpressionFactoryPairs = {
- type FrameKey = (String, FrameType, Expression, Expression)
+ type FrameKey = (String, FrameType, Expression, Expression,
Seq[Expression])
type ExpressionBuffer = mutable.Buffer[Expression]
val framedFunctions = mutable.Map.empty[FrameKey, (ExpressionBuffer,
ExpressionBuffer)]
// Add a function and its function to the map for a given frame.
def collect(tpe: String, fr: SpecifiedWindowFrame, e: Expression, fn:
Expression): Unit = {
- val key = (tpe, fr.frameType, fr.lower, fr.upper)
+ val key = fn match {
+ // This branch is used for Lead/Lag to support ignoring null.
+ // All window frames move in rows. If there are multiple Leads or Lags
acting on a row
+ // and operating on different input expressions, they should not be
moved uniformly
+ // by row. Therefore, we put these functions in different window
frames.
+ case f: FrameLessOffsetWindowFunction if f.ignoreNulls =>
+ (tpe, fr.frameType, fr.lower, fr.upper,
f.children.map(_.canonicalized))
+ case _ => (tpe, fr.frameType, fr.lower, fr.upper, null)
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
