dongjoon-hyun commented on a change in pull request #30790: URL: https://github.com/apache/spark/pull/30790#discussion_r544782946
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ########## @@ -470,6 +470,15 @@ object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper { case _ => false } + private def isAlwaysFalse(exps: Seq[Expression], equalTo: Literal): Boolean = { Review comment: Maybe, something like `notEqualForAll` instead of `isAlwaysFalse`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org