MaxGekk commented on a change in pull request #30799:
URL: https://github.com/apache/spark/pull/30799#discussion_r544852303
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
##########
@@ -388,7 +388,8 @@ case class CatalogTable(
def toLinkedHashMap: mutable.LinkedHashMap[String, String] = {
val map = new mutable.LinkedHashMap[String, String]()
- val tableProperties = properties.map(p => p._1 + "=" + p._2).mkString("[",
", ", "]")
+ val tableProperties = properties.toSeq.sortBy(_._1)
+ .map(p => p._1 + "=" + p._2).mkString("[", ", ", "]")
Review comment:
Should we sort by entire strings (._1 and ._2)? For example, if you have
`key0 = b` and `key0 = a`, you may get unstable output either `[key0 = b, key0
= a]` or `[key0 = a, key0 = b]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
