HyukjinKwon commented on a change in pull request #30790:
URL: https://github.com/apache/spark/pull/30790#discussion_r545560507
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -528,6 +528,40 @@ object SimplifyConditionals extends Rule[LogicalPlan] with
PredicateHelper {
}
+/**
+ * Push the foldable expression into (if / case) branches.
+ */
+object PushFoldableIntoBranches extends Rule[LogicalPlan] with PredicateHelper
{
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case q: LogicalPlan => q transformExpressionsUp {
+ case b @ BinaryExpression(i @ If(_, trueValue, falseValue), right) if
i.deterministic &&
+ right.foldable && (trueValue.foldable || falseValue.foldable) =>
Review comment:
Ohh, okay but we just want to push down foldables only that can have
benefits. gotya.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
