HyukjinKwon commented on a change in pull request #30868:
URL: https://github.com/apache/spark/pull/30868#discussion_r547084623
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
##########
@@ -457,7 +457,9 @@ object CatalystTypeConverters {
case d: JavaBigDecimal => new DecimalConverter(DecimalType(d.precision,
d.scale)).toCatalyst(d)
case seq: Seq[Any] => new
GenericArrayData(seq.map(convertToCatalyst).toArray)
case r: Row => InternalRow(r.toSeq.map(convertToCatalyst): _*)
- case arr: Array[Any] => new GenericArrayData(arr.map(convertToCatalyst))
+ case arr: Array[Byte] => arr
+ case arr: Array[Char] => StringConverter.toCatalyst(arr)
+ case arr: Array[_] => new GenericArrayData(arr.map(convertToCatalyst))
Review comment:
It already works without this change.
```scala
scala> Literal(Array(1, 2, 3))
res1: org.apache.spark.sql.catalyst.expressions.Literal = [1,2,3]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
