AngersZhuuuu commented on a change in pull request #30869:
URL: https://github.com/apache/spark/pull/30869#discussion_r548436302
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##########
@@ -920,9 +921,12 @@ object DDLUtils {
serde == Some("parquet.hive.serde.ParquetHiveSerDe") ||
serde ==
Some("org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe")) {
ParquetSchemaConverter.checkFieldNames(colNames)
+ } else if (serde == HiveSerDe.sourceToSerDe("avro").get.serde) {
+ AvroFileFormat.checkFieldNames(colNames)
}
case "parquet" => ParquetSchemaConverter.checkFieldNames(colNames)
case "orc" => OrcFileFormat.checkFieldNames(colNames)
+ case "avro" => AvroFileFormat.checkFieldNames(colNames)
Review comment:
Updated as your comment, but many test failed since
```
org.apache.spark.sql.AnalysisException: Failed to find data source: avro.
Avro is built-in but external data source module since Spark 2.4. Please deploy
the application as per the deployment section of "Apache Avro Data Source
Guide".
```
Then move all these test case to Avro module?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
