srowen commented on a change in pull request #30924:
URL: https://github.com/apache/spark/pull/30924#discussion_r549343608
##########
File path:
core/src/main/scala/org/apache/spark/rdd/SequenceFileRDDFunctions.scala
##########
@@ -32,16 +32,13 @@ import org.apache.spark.internal.Logging
* @note This can't be part of PairRDDFunctions because we need more implicit
parameters to
* convert our keys and values to Writable.
*/
-class SequenceFileRDDFunctions[K <% Writable: ClassTag, V <% Writable :
ClassTag](
+class SequenceFileRDDFunctions[K: IsWritable: ClassTag, V: IsWritable:
ClassTag](
Review comment:
I see, yeah we can't add implicits without changing the signature. Hm, I
can't think of other ways to write it. I think this change is OK. I'd leave a
note in the comments of IsWritable about why it exists, with a link to the
suggestion from scala Q&A.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
