Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4015#discussion_r28745812
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -130,18 +170,35 @@ class SQLContext(@transient val sparkContext:
SparkContext)
protected[sql] lazy val optimizer: Optimizer = DefaultOptimizer
@transient
- protected[sql] val ddlParser = new DDLParser(sqlParser.apply(_))
-
- @transient
- protected[sql] val sqlParser = {
- val fallback = new catalyst.SqlParser
- new SparkSQLParser(fallback(_))
+ protected[sql] val ddlParser = new DDLParser((sql: String) => {
getSQLDialect().parse(sql) })
+ protected[sql] def dialectCache = tlSession.get().dialectCache
--- End diff --
I know we talked about this briefly, but its still unclear to me why you
need this. You are still making reflective calls on a per statement basis? It
seems unlikely to me that caching the result of `newInstance` is really that
important. Can you clarify and if its absolutely not possible to remove this
explain why in a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
