beliefer commented on a change in pull request #30981: URL: https://github.com/apache/spark/pull/30981#discussion_r551131619
########## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/strings.sql.out ########## @@ -977,7 +977,7 @@ struct<repeat(Pg, -4):string> -- !query SELECT trim(binary('\\000') from binary('\\000Tom\\000')) Review comment: The current implementation only supports `string`, but because `ImplicitCastInputTypes` is used, `binary` is cast into `string`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org