turboFei commented on a change in pull request #29982:
URL: https://github.com/apache/spark/pull/29982#discussion_r551173235
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -573,4 +573,53 @@ class CliSuite extends SparkFunSuite with
BeforeAndAfterAll with Logging {
// the date formatter for `java.sql.LocalDate` must output negative years
with sign.
runCliWithin(1.minute)("SELECT MAKE_DATE(-44, 3, 15);" -> "-0044-03-15")
}
+
+ test("SPARK-33100: Ignore a semicolon inside a bracketed comment in
spark-sql") {
+ runCliWithin(1.minute)("/* SELECT 'test';*/ SELECT 'test';" -> "test" )
+ runCliWithin(1.minute)(";;/* SELECT 'test';*/ SELECT 'test';" -> "test" )
+ runCliWithin(1.minute)("/* SELECT 'test';*/;; SELECT 'test';" -> "test" )
+ runCliWithin(1.minute)("SELECT 'test'; -- SELECT 'test';" -> "")
+ runCliWithin(1.minute)("SELECT 'test'; /* SELECT 'test';*/" -> "")
+ runCliWithin(1.minute)("/*$meta chars{^\\;}*/ SELECT 'test';" -> "test")
+ runCliWithin(1.minute)("/*\nmulti-line\n*/ SELECT 'test';" -> "test")
+ runCliWithin(1.minute)("/*/* multi-level bracketed*/ SELECT 'test';" ->
"test")
+
+ val dataFilePath =
+
Thread.currentThread().getContextClassLoader.getResource("data/files/small_kv.txt")
Review comment:
plan for `select /* + broadcast(t) */ * from t`
```
== Parsed Logical Plan ==
'Project [*]
+- 'UnresolvedRelation [t], [], false
== Analyzed Logical Plan ==
k: int, v: int
Project [k#218, v#219]
+- SubqueryAlias t
+- Project [k#218, v#219]
+- SubqueryAlias t
+- LocalRelation [k#218, v#219]
== Optimized Logical Plan ==
LocalRelation [k#218, v#219]
== Physical Plan ==
LocalTableScan [k#218, v#219]
```
I can not find the way to match result for this case.
Because the `captureOutput` method captures output from source `output` one
line by one line.
It can not match two continue lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
