LuciferYang opened a new pull request #31064:
URL: https://github.com/apache/spark/pull/31064


   ### What changes were proposed in this pull request?
   There is one compilation warning as follow:
   
   ```
   [WARNING] [Warn] 
/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:1555:
 [other-match-analysis @ 
org.apache.spark.sql.catalyst.catalog.SessionCatalog.lookupFunction.catalogFunction]
 unreachable code
   ```
   
   This compilation warning is due to `NoSuchPermanentFunctionException` is 
sub-class of `AnalysisException` and if there is 
`NoSuchPermanentFunctionException` be thrown out, it will be catch by `case _: 
AnalysisException => failFunctionLookup(name)`,  so `case _: 
NoSuchPermanentFunctionException => failFunctionLookup(name)` is `unreachable 
code` .
   
   This pr remove `case _: NoSuchPermanentFunctionException => 
failFunctionLookup(name)` directly because both these 2 branches handle 
exceptions in the same way.
   
   
   ### Why are the changes needed?
   Cleanup "unreachable code" compilation warnings.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Pass the Jenkins or GitHub Action
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to