Github user shenh062326 commented on the pull request:
https://github.com/apache/spark/pull/5608#issuecomment-94754171
No, the change has no matter with the check for null.
If the arraySize > 200, and elem has the share object, the
SizeEstimator.visitArray is not correct.
for example, arraySize=20000, all the array elem has a share object with
1000000B and not share object 50B, the truely size is
20000*50B+1000000B=2*10^B , but currently, SizeEstimator.visitArray will
return (100* 50Bã+ 1000000B ) * 20000/100=201*10^6B, It's more than 100 times
than the truely size. Furthermore is the array is greater, the greater the
multiplier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
