Github user scwf commented on the pull request: https://github.com/apache/spark/pull/5610#issuecomment-94803483 @DoingDone9 as we discussed offline, here are some problems in this PR 1 When the extracted `condition` is not None and it also not the join predicates we do not need change it as ShuffledHashJoin 2 we also should fix it for the BroadcastLeftSemiJoinHash I have make a new PR for this, please have a look. #5612
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org