Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5467#discussion_r28813287
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -429,7 +429,25 @@ class Word2Vec extends Serializable with Logging {
*/
@Experimental
class Word2VecModel private[mllib] (
- private val model: Map[String, Array[Float]]) extends Serializable
with Saveable {
+ model: Map[String, Array[Float]]) extends Serializable with Saveable {
+
+ // Maintain a ordered list of words based on the index in the initial
model.
+ private val wordList: Array[String] = model.keys.toArray
--- End diff --
Yes, please, a little one-line comment for each value would be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
