zhengruifeng commented on a change in pull request #30999:
URL: https://github.com/apache/spark/pull/30999#discussion_r554793464
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -349,11 +349,19 @@ abstract class Optimizer(catalogManager: CatalogManager)
*/
object EliminateDistinct extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan = plan
transformExpressions {
- case ae: AggregateExpression if ae.isDistinct =>
- ae.aggregateFunction match {
- case _: Max | _: Min => ae.copy(isDistinct = false)
- case _ => ae
- }
+ case ae: AggregateExpression if ae.isDistinct &&
isDuplicateAgnostic(ae.aggregateFunction) =>
+ ae.copy(isDistinct = false)
+ }
+
+ private def isDuplicateAgnostic(af: AggregateFunction): Boolean = af match {
+ case _: Max => true
+ case _: Min => true
+ case _: BitAndAgg => true
+ case _: BitOrAgg => true
+ case _: First => true
Review comment:
If we finally make `First` and `Last` deterministic, then I guess they
need to be removed from `EliminateDistinct`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
