Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5538#discussion_r28839390
--- Diff:
sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim12.scala ---
@@ -135,7 +135,13 @@ private[hive] object HiveShim {
PrimitiveCategory.VOID, null)
def getStringWritable(value: Any): hadoopIo.Text =
- if (value == null) null else new
hadoopIo.Text(value.asInstanceOf[UTF8String].toString)
+ if (value == null) {
+ null
+ } else if (value.isInstanceOf[String]) {
+ new hadoopIo.Text(value.asInstanceOf[String])
+ } else {
+ new hadoopIo.Text(value.asInstanceOf[UTF8String].toString)
+ }
--- End diff --
That's actually my concern, not every developer knows exactly how the
`foldable` work in Hive UDF, I don't think we need to implement this Hive UDF
at all. We can just return the `Literal(database, StringType)` in
`HiveFunctionRegistry.lookupFunction` instead of creating the Hive UDF and
register it, which seems a hack way to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
