Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5428#discussion_r28841272
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
    @@ -271,7 +282,10 @@ object CheckpointReader extends Logging {
         })
     
         // If none of checkpoint files could be read, then throw exception
    -    throw new SparkException("Failed to read checkpoint from directory " + 
checkpointPath)
    +    if (!ignoreReadError) {
    +      throw new SparkException("Failed to read checkpoint from directory " 
+ checkpointPath)
    --- End diff --
    
    Do you think that we should log a warning message in the case where we 
ignore the error?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to