cloud-fan commented on a change in pull request #31216: URL: https://github.com/apache/spark/pull/31216#discussion_r559350436
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala ########## @@ -44,4 +44,13 @@ class AlterTableAddPartitionSuite checkPartitions(t, Map("p1" -> "")) } } + + test("SPARK-34143: add a partition to fully partitioned table") { + withNamespaceAndTable("ns", "tbl") { t => + sql(s"CREATE TABLE $t (p0 INT, p1 STRING) $defaultUsing PARTITIONED BY (p0, p1)") Review comment: Currently, we do not disallow it so I'm fine to fix the testing v2 catalog implementation. But we should figure out if we should allow fully partitioned table or not later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org