MaxGekk commented on a change in pull request #31229:
URL: https://github.com/apache/spark/pull/31229#discussion_r559453303
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala
##########
@@ -44,22 +45,25 @@ case class AlterTableAddPartitionExec(
table.name(), existsParts.map(_.ident), table.partitionSchema())
}
- notExistsParts match {
- case Seq() => // Nothing will be done
+ val isTableAltered = notExistsParts match {
+ case Seq() => false // Nothing will be done
case Seq(partitionSpec) =>
val partProp = partitionSpec.location.map(loc => "location" ->
loc).toMap
table.createPartition(partitionSpec.ident, partProp.asJava)
+ true
Review comment:
ok. If we look at `dropTable()`, I wonder why it returns `false` when a
table doesn't exist:
https://github.com/apache/spark/blob/ec1560af251d2c3580f5bccfabc750f1c7af09df/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java#L171
though other methods in the same interface throw an exception:
https://github.com/apache/spark/blob/ec1560af251d2c3580f5bccfabc750f1c7af09df/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java#L157
This looks inconsistent to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
