yaooqinn edited a comment on pull request #31199: URL: https://github.com/apache/spark/pull/31199#issuecomment-761732525
# Codegen vs NonCodegen reslut from master the performance itself does not change much, because the purpose here is to prevent queries from fallback to non-codegen ```logtalk ================================================================================================ Char Varchar Read Side Perf ================================================================================================ Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read char with length 20: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ read char with length 20 wholestage off 4830 5393 796 20.7 48.3 1.0X read char with length 20 wholestage on 1693 1755 42 59.1 16.9 2.9X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read varchar with length 20: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative -------------------------------------------------------------------------------------------------------------------------- read varchar with length 20 wholestage off 4763 4884 171 21.0 47.6 1.0X read varchar with length 20 wholestage on 1802 1888 59 55.5 18.0 2.6X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read char with length 40: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ read char with length 40 wholestage off 4685 4718 46 21.3 46.9 1.0X read char with length 40 wholestage on 1858 1904 39 53.8 18.6 2.5X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read varchar with length 40: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative -------------------------------------------------------------------------------------------------------------------------- read varchar with length 40 wholestage off 4730 4749 27 21.1 47.3 1.0X read varchar with length 40 wholestage on 1738 1831 99 57.5 17.4 2.7X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read char with length 60: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ read char with length 60 wholestage off 4936 4984 68 20.3 49.4 1.0X read char with length 60 wholestage on 1787 1835 46 55.9 17.9 2.8X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read varchar with length 60: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative -------------------------------------------------------------------------------------------------------------------------- read varchar with length 60 wholestage off 4642 4740 138 21.5 46.4 1.0X read varchar with length 60 wholestage on 1694 1755 48 59.0 16.9 2.7X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read char with length 80: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ read char with length 80 wholestage off 4709 4736 38 21.2 47.1 1.0X read char with length 80 wholestage on 1787 1869 76 56.0 17.9 2.6X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz read varchar with length 80: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative -------------------------------------------------------------------------------------------------------------------------- read varchar with length 80 wholestage off 4613 4721 153 21.7 46.1 1.0X read varchar with length 80 wholestage on 1757 1814 59 56.9 17.6 2.6X ================================================================================================ Char Varchar Write Side Perf ================================================================================================ Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write char with length 20: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ write char with length 20 wholestage off 7312 7439 180 1.4 731.2 1.0X write char with length 20 wholestage on 5957 6332 355 1.7 595.7 1.2X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write varchar with length 20: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative --------------------------------------------------------------------------------------------------------------------------- write varchar with length 20 wholestage off 9318 10265 1339 1.1 931.8 1.0X write varchar with length 20 wholestage on 8722 9268 512 1.1 872.2 1.1X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write char with length 40: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ write char with length 40 wholestage off 10051 10257 292 1.0 1005.1 1.0X write char with length 40 wholestage on 8534 8917 316 1.2 853.4 1.2X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write varchar with length 40: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative --------------------------------------------------------------------------------------------------------------------------- write varchar with length 40 wholestage off 13713 14250 759 0.7 1371.3 1.0X write varchar with length 40 wholestage on 12070 12609 516 0.8 1207.0 1.1X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write char with length 60: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ write char with length 60 wholestage off 11728 12975 1763 0.9 1172.8 1.0X write char with length 60 wholestage on 10211 10515 256 1.0 1021.1 1.1X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write varchar with length 60: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative --------------------------------------------------------------------------------------------------------------------------- write varchar with length 60 wholestage off 17845 17924 113 0.6 1784.5 1.0X write varchar with length 60 wholestage on 16338 17353 1330 0.6 1633.8 1.1X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write char with length 80: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ write char with length 80 wholestage off 14381 14656 390 0.7 1438.1 1.0X write char with length 80 wholestage on 13991 14556 455 0.7 1399.1 1.0X Java HotSpot(TM) 64-Bit Server VM 1.8.0_251-b08 on Mac OS X 10.16 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz write varchar with length 80: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative --------------------------------------------------------------------------------------------------------------------------- write varchar with length 80 wholestage off 21476 22547 1515 0.5 2147.6 1.0X write varchar with length 80 wholestage on 21092 22393 899 0.5 2109.2 1.0X ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org