HyukjinKwon commented on a change in pull request #31244: URL: https://github.com/apache/spark/pull/31244#discussion_r560076501
########## File path: core/src/main/scala/org/apache/spark/util/Utils.scala ########## @@ -1939,7 +1939,15 @@ private[spark] object Utils extends Logging { * Indicates whether Spark is currently running unit tests. */ def isTesting: Boolean = { Review comment: I understand that this change tried to be conservative to avoid any breakage but `isTesting` isn't an API (it's `private[spark] object Utils` so it's fine to directly change `def isTesting` to `lazy val isTesting` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org