Github user piaozhexiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5617#discussion_r28883339
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -77,12 +77,8 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
if (verbose) SparkSubmit.printStream.println(s"Using properties file:
$propertiesFile")
Option(propertiesFile).foreach { filename =>
Utils.getPropertiesFromFile(filename).foreach { case (k, v) =>
- if (k.startsWith("spark.")) {
--- End diff --
The reason why I moved the logic of removing non-spark properties out of
this loop is because properties that are loaded from the command line (--conf)
cannot be filtered here. So I decided to remove non-spark properties after
properties from the config file and the command line are merged.
Please let me know if you have a better suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
