sunchao commented on a change in pull request #31284:
URL: https://github.com/apache/spark/pull/31284#discussion_r562776331
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##########
@@ -122,7 +123,19 @@ public VectorizedColumnReader(
DictionaryPage dictionaryPage = pageReader.readDictionaryPage();
if (dictionaryPage != null) {
try {
- this.dictionary =
dictionaryPage.getEncoding().initDictionary(descriptor, dictionaryPage);
+ PrimitiveType primitiveType = descriptor.getPrimitiveType();
+ if (primitiveType.getOriginalType() == OriginalType.DECIMAL &&
Review comment:
could you add some comments for this code? also why it only affects
vectorized read path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
