Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5630#discussion_r28937324
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -36,6 +36,8 @@ private[spark] object SQLConf {
val PARQUET_INT96_AS_TIMESTAMP = "spark.sql.parquet.int96AsTimestamp"
val PARQUET_CACHE_METADATA = "spark.sql.parquet.cacheMetadata"
val PARQUET_COMPRESSION = "spark.sql.parquet.compression.codec"
+ val PARQUET_BLOCK_SIZE = "spark.sql.parquet.blocksize"
+ val PARQUET_PAGE_SIZE = "spark.sql.parquet.pagesize"
--- End diff --
I meant Parquet should have its own conf keys for those, right? I do not
need to add spark sql ones.
See
https://github.com/apache/parquet-mr/blob/parquet-1.6.0rc3/parquet-hadoop/src/main/java/parquet/hadoop/ParquetOutputFormat.java#L98-L106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
