cloud-fan commented on a change in pull request #31319:
URL: https://github.com/apache/spark/pull/31319#discussion_r564560578
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
##########
@@ -88,7 +88,7 @@ class ParquetReadSupport(
SQLConf.NESTED_SCHEMA_PRUNING_ENABLED.defaultValue.get)
val parquetFileSchema = context.getFileSchema
val parquetClippedSchema =
ParquetReadSupport.clipParquetSchema(parquetFileSchema,
Review comment:
IIUC `clipParquetSchema` is not designed to check schema mismatch. We
should put the check in the readers. It's also better to do so, as reader
implementation decides how the check should be done.
I opened a PR to do it: https://github.com/apache/spark/pull/31347 . Feel
free to incorporate it in your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
