razajafri commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-768066093
> I think this can be revised a bit to make it more understandable. I guess another approach is to initialize the `WriteColumnVector` to use `long` array instead of `int`. It will use more memory but perhaps performance will be better, and the code could be much simpler. So, I thought about doing it that way but I didn't think it will be beneficial to have the general-case implementation suffer from using more memory for a fringe case such as this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
