[GitHub] [spark] HyukjinKwon commented on a change in pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

[GitBox]

HyukjinKwon commented on a change in pull request #31148:
URL: https://github.com/apache/spark/pull/31148#discussion_r565239091



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -175,7 +179,14 @@ abstract class JdbcDialect extends Serializable with 
Logging{
   def compileValue(value: Any): Any = value match {
     case stringValue: String => s"'${escapeSql(stringValue)}'"
     case timestampValue: Timestamp => "'" + timestampValue + "'"
+    case timestampValue: Instant =>
+      val timestampFormatter = TimestampFormatter.getFractionFormatter(
+        DateTimeUtils.getZoneId(SQLConf.get.sessionLocalTimeZone))
+      "'" + timestampFormatter.format(timestampValue) + "'"

Review comment:
       no big deal but I would use 
`s"'${timestampFormatter.format(timestampValue)}'"` string interpolation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org