cloud-fan commented on a change in pull request #31349:
URL: https://github.com/apache/spark/pull/31349#discussion_r565394361



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -211,34 +105,27 @@ object TypeCoercion {
    * i.e. the main difference with [[findTightestCommonType]] is that here we 
allow some
    * loss of precision when widening decimal and double, and promotion to 
string.

Review comment:
       `... promotion to string` seems not true for ansi mode?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to