cloud-fan commented on a change in pull request #31368:
URL: https://github.com/apache/spark/pull/31368#discussion_r565561910
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
##########
@@ -230,7 +230,7 @@ object LogicalPlanIntegrity {
// NOTE: we still need to filter resolved expressions here because the
output of
// some resolved logical plans can have unresolved references,
// e.g., outer references in `ExistenceJoin`.
- p.output.filter(_.resolved).map { a => (a.exprId, a.dataType) }
+ p.output.filter(_.resolved).map { a => (a.exprId, a.dataType.asNullable)
}
Review comment:
@maropu We can eliminate cast for complex types that are compatible
(only nullability is different), so the previous logic could fail valid queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
