maropu commented on a change in pull request #31286: URL: https://github.com/apache/spark/pull/31286#discussion_r565773596
########## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/join.sql ########## @@ -743,20 +743,20 @@ select * from a left join b on i = x and i = y and x = i; -- -- test NULL behavior of whole-row Vars, per bug #5025 -- -select t1.q2, count(t2.*) +select t1.q2, count(t2.q1, t2.q2) Review comment: +1 for the @cloud-fan advice. Also, could you leave some comment there about why we change the original test query? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org