AngersZhuuuu commented on a change in pull request #31341:
URL: https://github.com/apache/spark/pull/31341#discussion_r565776888
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -972,10 +972,9 @@ case class ShowColumnsCommand(
*/
case class ShowPartitionsCommand(
tableName: TableIdentifier,
+ attributes: Seq[Attribute],
Review comment:
> why not just name this parameter `output`?
Never wrote like this before, lookup the code, some places write like that.
Update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
