cloud-fan commented on a change in pull request #31368:
URL: https://github.com/apache/spark/pull/31368#discussion_r566575428
##########
File path: sql/core/src/test/resources/sql-tests/results/group-by-filter.sql.out
##########
@@ -796,14 +796,16 @@ IN/EXISTS predicate sub-queries can only be used in
Filter/Join and a few comman
: +- Filter (dept_id#x = outer(dept_id#x))
: +- SubqueryAlias dept
: +- View (`DEPT`, [dept_id#x,dept_name#x,state#x])
-: +- Project [dept_id#x, dept_name#x, state#x]
-: +- SubqueryAlias DEPT
-: +- LocalRelation [dept_id#x, dept_name#x, state#x]
+: +- Project [cast(dept_id#x as int) AS dept_id#x,
cast(dept_name#x as string) AS dept_name#x, cast(state#x as string) AS state#x]
Review comment:
It's better to delay the cast adding (after the parsed view plan is
resolved), so that we can skip adding cast for views that have no schema
changing. But I can't find an easy way to do it and this is really not a big
deal (optimizer willl remove redundant casts), so I go with the simple approach
for maintainability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
