dongjoon-hyun commented on a change in pull request #31369:
URL: https://github.com/apache/spark/pull/31369#discussion_r566976528
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -165,10 +165,18 @@ case class StateStoreMetrics(
object StateStoreMetrics {
def combine(allMetrics: Seq[StateStoreMetrics]): StateStoreMetrics = {
+ val distinctCustomMetrics =
allMetrics.flatMap(_.customMetrics.keys).distinct
+ val customMetrics = allMetrics.flatMap(_.customMetrics)
+ val combinedCustomMetrics = distinctCustomMetrics.map { customMetric =>
+ val sameMetrics = customMetrics.filter(_._1 == customMetric)
+ val sumOfMetrics = sameMetrics.map(_._2).sum
Review comment:
Just a question. Is it valid for all classes using
`StateStoreCustomMetric` trait? At least for the following three in Spark.
```
case class StateStoreCustomSumMetric(name: String, desc: String) extends
StateStoreCustomMetric
case class StateStoreCustomSizeMetric(name: String, desc: String) extends
StateStoreCustomMetric
case class StateStoreCustomTimingMetric(name: String, desc: String) extends
StateStoreCustomMetric
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
