HyukjinKwon commented on a change in pull request #31401:
URL: https://github.com/apache/spark/pull/31401#discussion_r567363021
##########
File path: python/pyspark/sql/avro/functions.py
##########
@@ -37,7 +37,7 @@ def from_avro(data, jsonFormatSchema, options=None):
Parameters
----------
- data : :class:`Column` or str
+ data : :class:`pyspark.sql.Column` or str
Review comment:
IIRC, it doesn't have to be fully qualified import path. `Column` is
already being imported in this file. For example, it works for ``
`:class:`DataFrame` ``, see
https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.sql.DataFrameReader.csv.html#pyspark.sql.DataFrameReader.csv
and
https://github.com/apache/spark/blob/master/python/pyspark/sql/readwriter.py#L527
Can you investigate why it doesn't work here with `Column`? I would like to
avoid making it as a fully qualified form which seems unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
