imback82 commented on a change in pull request #31422:
URL: https://github.com/apache/spark/pull/31422#discussion_r568074584
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -431,6 +431,17 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
val changes = Seq(TableChange.setProperty(TableCatalog.PROP_LOCATION,
location))
AlterTableExec(table.catalog, table.identifier, changes) :: Nil
+ case AlterTableSetProperties(table: ResolvedTable, props) =>
+ val changes = props.map { case (key, value) =>
+ TableChange.setProperty(key, value)
+ }.toSeq
+ AlterTableExec(table.catalog, table.identifier, changes) :: Nil
+
+ // TODO: v2 `UNSET TBLPROPERTIES` should respect the ifExists flag.
Review comment:
I will handle this after this PR is merged; much easier to handle with
new framework.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -431,6 +431,17 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
val changes = Seq(TableChange.setProperty(TableCatalog.PROP_LOCATION,
location))
AlterTableExec(table.catalog, table.identifier, changes) :: Nil
+ case AlterTableSetProperties(table: ResolvedTable, props) =>
+ val changes = props.map { case (key, value) =>
+ TableChange.setProperty(key, value)
+ }.toSeq
+ AlterTableExec(table.catalog, table.identifier, changes) :: Nil
+
+ // TODO: v2 `UNSET TBLPROPERTIES` should respect the ifExists flag.
Review comment:
I will handle this TODO after this PR is merged; much easier to handle
with new framework.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
