AngersZhuuuu commented on a change in pull request #31378:
URL: https://github.com/apache/spark/pull/31378#discussion_r568352532
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##########
@@ -129,7 +129,7 @@ class HiveCommandSuite extends QueryTest with SQLTestUtils
with TestHiveSingleto
checkAnswer(
sql(s"SHOW TBLPROPERTIES parquet_tab1('my_key1')"),
- Row("v1") :: Nil
+ Row("my_key1", "v1") :: Nil
Review comment:
> > then shall we change the schema of the v2 command?
>
> IMO, change `ShowTablePropertiesCommand` is correct since hive's output
schema is `prpt_name` and `prpt_value`, I think hive is wrong before.
Also ping @wangyum @beliefer @viirya Also hope your suggestion since I
believe it's a hive's bug and we don't need to follow wrong behavior in hive
1.x and 2.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
