offthewall123 commented on a change in pull request #31433:
URL: https://github.com/apache/spark/pull/31433#discussion_r568370590
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala
##########
@@ -20,12 +20,11 @@ package org.apache.spark.shuffle.sort
import org.apache.spark._
import org.apache.spark.internal.{config, Logging}
import org.apache.spark.scheduler.MapStatus
-import org.apache.spark.shuffle.{BaseShuffleHandle, IndexShuffleBlockResolver,
ShuffleWriter}
+import org.apache.spark.shuffle.{BaseShuffleHandle, ShuffleWriter}
import org.apache.spark.shuffle.api.ShuffleExecutorComponents
import org.apache.spark.util.collection.ExternalSorter
private[spark] class SortShuffleWriter[K, V, C](
- shuffleBlockResolver: IndexShuffleBlockResolver,
Review comment:
Yes, it's not used here, i think someone forget to remove this when
separate this part logic to LocalDiskShuffleDataIO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
