AngersZhuuuu commented on a change in pull request #31402: URL: https://github.com/apache/spark/pull/31402#discussion_r568501936
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ########## @@ -3162,6 +3162,9 @@ class Analyzer(override val catalogManager: CatalogManager) case WindowExpression(wf: FrameLessOffsetWindowFunction, WindowSpecDefinition(_, _, f: SpecifiedWindowFrame)) if wf.frame != f => throw QueryCompilationErrors.cannotSpecifyWindowFrameError(wf.prettyName) + case WindowExpression(wf: AggregateWindowFunction, s: WindowSpecDefinition) + if wf.frame != UnspecifiedFrame => + WindowExpression(wf, s.copy(frameSpecification = wf.frame)) Review comment: > This block is to use the default frame regardless of the specified frame ? Yea..PG do like this == ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org