sunchao commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r570011001
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -909,12 +909,12 @@ class SessionCatalog(
isTempView(nameParts.asTableIdentifier)
}
- private def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
+ def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
val tableName = formatTableName(name.table)
if (name.database.isEmpty) {
- tempViews.get(tableName)
+ tempViews.get(tableName).map(getTempViewPlan)
} else if (formatDatabaseName(name.database.get) ==
globalTempViewManager.database) {
- globalTempViewManager.get(tableName)
+ globalTempViewManager.get(tableName).map(getTempViewPlan)
Review comment:
Yes. This is added so we can pass a parsed view plan to
`CatalogImpl.uncacheView`. I _think_ it also fixes a potential issue in
`refreshTable` where `refresh` is called on `TemporaryViewRelation` instead of
`View`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
