cloud-fan commented on a change in pull request #31258:
URL: https://github.com/apache/spark/pull/31258#discussion_r570212611
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala
##########
@@ -146,10 +146,15 @@ abstract class QueryStageExec extends LeafExecNode {
/**
* A shuffle query stage whose child is a [[ShuffleExchangeLike]] or
[[ReusedExchangeExec]].
+ *
+ * @param id the query stage id.
+ * @param plan the underlying plan.
+ * @param _canonicalized the canonicalized plan before applying query stage
optimizer rules.
*/
case class ShuffleQueryStageExec(
override val id: Int,
- override val plan: SparkPlan) extends QueryStageExec {
+ override val plan: SparkPlan,
+ _canonicalized: SparkPlan) extends QueryStageExec {
Review comment:
we missed to add `override def doCanonicalize(): SparkPlan =
_canonicalized`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
