razajafri commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-773471709
> Do we need to change this part? > > https://github.com/apache/spark/blob/3a361cd837eeea5b5c82b0f90f5d1987a8a30328/sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java#L383-L392 I don't think we do. The reason is that the dictionary was initialized correctly after we changed the descriptor so we shouldn't have a problem decoding it. I could be wrong, @revans2 do you agree? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
