cloud-fan commented on a change in pull request #31284:
URL: https://github.com/apache/spark/pull/31284#discussion_r570954035
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##########
@@ -147,7 +150,24 @@ public VectorizedColumnReader(
DictionaryPage dictionaryPage = pageReader.readDictionaryPage();
if (dictionaryPage != null) {
try {
- this.dictionary =
dictionaryPage.getEncoding().initDictionary(descriptor, dictionaryPage);
+ PrimitiveType primitiveType = descriptor.getPrimitiveType();
+ if (primitiveType.getOriginalType() == OriginalType.DECIMAL &&
+ primitiveType.getDecimalMetadata().getPrecision() <=
Decimal.MAX_INT_DIGITS() &&
+ primitiveType.getPrimitiveTypeName() == INT64) {
+ // We need to make sure that we initialize the right type for the
dictionary otherwise
+ // Encoding#initDictionary will initialize it to
PrimitiveTypeName.INT64 and
+ // WritableColumnVector will throw an exception when trying to
decode to an Int when the
+ // dictionary is in fact initialized as Long
+ PrimitiveType adjustedType = new
PrimitiveType(primitiveType.getRepetition(),
+ INT32, primitiveType.getTypeLength(),
+ primitiveType.getName(), primitiveType.getOriginalType(),
+ primitiveType.getDecimalMetadata(), primitiveType.getId());
+ ColumnDescriptor desc = new ColumnDescriptor(descriptor.getPath(),
+ adjustedType, descriptor.getMaxRepetitionLevel(),
descriptor.getMaxDefinitionLevel());
+ this.dictionary = dictionaryPage.getEncoding().initDictionary(desc,
dictionaryPage);
Review comment:
@razajafri I see that here we initialize the dictionary with an adjusted
`ColumnDescriptor`. I'm curious about where the INT64 -> INT32 happens. Inside
the parquet MR library?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
