AngersZhuuuu commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571528357
########## File path: docs/sql-migration-guide.md ########## @@ -56,6 +56,8 @@ license: | In Spark 3.1 and earlier, table refreshing leaves dependents uncached. - In Spark 3.2, the usage of `count(tblName.*)` is blocked to avoid producing ambiguous results. Because `count(*)` and `count(tblName.*)` will output differently if there is any null values. To restore the behavior before Spark 3.2, you can set `spark.sql.legacy.allowStarWithSingleTableIdentifierInCount` to `true`. + + - In Spark 3.2, a `SHOW TBLPROPERTIES` clause's output shows `key` and `value` columns whether you specify the table property `key` or not. In Spark 3.1 and earlier, a `SHOW TBLPROPERTIES` clause's output only shows a `value` column when you specify the table property `key`. Review comment: > can we follow https://github.com/apache/spark/pull/31245/files#diff-b6c16c7a1a4e60bacda4674b52f9eecde3c8a86f281fb3ef21052267f94c1f01R44 ? How about current? ########## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ########## @@ -490,8 +490,8 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager) throw QueryCompilationErrors.externalCatalogNotSupportShowViewsError(resolved) } - case ShowTableProperties(ResolvedV1TableOrViewIdentifier(ident), propertyKey) => - ShowTablePropertiesCommand(ident.asTableIdentifier, propertyKey) + case s @ ShowTableProperties(ResolvedV1TableOrViewIdentifier(ident), propertyKey) => Review comment: > and implement the legacy fallback How about current? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org