Ngone51 commented on pull request #31369:
URL: https://github.com/apache/spark/pull/31369#issuecomment-774929505
Hopefully, callers in the future could be always aware that
`StateStoreMetrics` is combined by `StateStoreCustomMetric` rather than
`StateStoreCustomMetric.name`. Otherwise, usages like
```scala
combinedMetrics.customMetrics.foreach { case (metric, value) =>
longMetric(metric.name) = value
^ "=" instead of "+="
}
```
could result in the wrong metrics again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
