Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5687#discussion_r29041932
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala
---
@@ -51,8 +51,8 @@ class Node (
var stats: Option[InformationGainStats]) extends Serializable with
Logging {
override def toString: String = {
- "id = " + id + ", isLeaf = " + isLeaf + ", predict = " + predict + ",
" +
--- End diff --
These can use string interpolation. I take your point though it breaks the
symmetry a bit and make this `toString` rely on details of the subclass. How
about making the `Predict.toString` return something more compact like
`s"$predict ($prob)"`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
